-
Notifications
You must be signed in to change notification settings - Fork 0
Schema refresh fix INC-8256 #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema refresh fix INC-8256 #262
Conversation
| final MongoDbSnapshotContext mongoDbSnapshotContext = (MongoDbSnapshotContext) snapshotContext; | ||
|
|
||
| LOGGER.info("Snapshot step 1 - Preparing"); | ||
| LOGGER.info("Logging here to know image build was successful") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this log anymore
| } | ||
|
|
||
| LOGGER.info("Starting streaming"); | ||
| LOGGER.info("Logging for validation"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this as well
akanimesh7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naveenmall11 Are we going ahead with test logs ?
| @@ -142,7 +141,6 @@ protected void lockTablesForSchemaSnapshot(ChangeEventSourceContext sourceContex | |||
| LOGGER.info("Waiting a maximum of '{}' seconds for each table lock", lockTimeout.getSeconds()); | |||
| jdbcConnection.executeWithoutCommitting(statements.toString()); | |||
| // now that we have the locks, refresh the schema | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the comment too
| stream.startKeepAlive( | ||
| Threads.newSingleThreadExecutor(PostgresConnector.class, connectorConfig.getLogicalName(), KEEP_ALIVE_THREAD_NAME, threadNameContext)); | ||
|
|
||
| initSchema(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashisrivastava-confluent For my understanding, init schema before starting streaming is not required, because streaming starts exactly from the point noted during snapshot. Is it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
f3170e3
into
v3.0.8-hotfix-x
Remove redundant calls for refresh schema
Upstream ticket: https://issues.redhat.com/browse/DBZ-8595
Upstream fix: debezium#6194
https://confluent.slack.com/archives/C0A83JB5UMR/p1768578389214619
Upstream fix: debezium#7022