Skip to content

Show stdout and stderr with failure in remote account#369

Open
imcdo wants to merge 4 commits intoconfluentinc:masterfrom
imcdo:print-stdout-stderr-on-fail
Open

Show stdout and stderr with failure in remote account#369
imcdo wants to merge 4 commits intoconfluentinc:masterfrom
imcdo:print-stdout-stderr-on-fail

Conversation

@imcdo
Copy link
Member

@imcdo imcdo commented Nov 21, 2022

Currently on failure we don't attach stderr and stdout of a command (we do stderr sometimes but its not consistant. This pr achieves that by passing in stdout and stderr to the error.

It also solves the problem of potentially storing to much data in memory (lets say stdout of a long running task) by capturing stdout and stderr in ring buffers, and storing only the last 32 lines to be printed.

This pr is to follow up on this pr: #234 by @stanislavkozlovski

@imcdo imcdo requested a review from a team November 21, 2022 22:21
@imcdo imcdo requested a review from a team February 2, 2023 19:34
@cla-assistant
Copy link

cla-assistant bot commented Aug 16, 2023

CLA assistant check
All committers have signed the CLA.

@imcdo imcdo enabled auto-merge (squash) September 27, 2024 17:25
@imcdo imcdo disabled auto-merge March 14, 2025 17:34
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants