Acceptor Dynamic Session Templates by pvkv1799 · Pull Request #607 · connamara/quickfixn

pvkv1799 · 2020-06-03T20:22:41Z

Enables "*" wildcard in Acceptor session configuration (for BeginString, SenderCompID, SenderSubID, SenderLocationID, TargetCompID, TargetSubID, and TargetLocationID).
Such session templates can be defined either at start-up or as an ad-hoc operation, just like "normal" sessions.
When processing a new incoming connection, if incoming SessionID is not equal to any of the created sessions, it is then matched considering wildcards. If such a match is found, the new session is created with the same settings as the template one, just changing wildcards to the actual values from incoming SessionID.

gbirchmeier

Ok, first off, this is going to have some conflicts with #609. That's not a big PR, but it does make a few changes to Session and SessionFactory. I hope to merge #609 today.

I'm not crazy about the acceptor-specific additions to Session. Can we think of any other approach? Making a DynamicSession subclass seems possible off the top of my head, but also could be horrible.

Don't go deep into any big changes yet. I also want to talk to @mgatny and see what ideas he has.

QuickFIXn/Session.cs

gbirchmeier · 2020-06-10T17:01:56Z

QuickFIXn/FileLog.cs

+        /// Handles wildcards in SessionID fields
+        /// </summary>
+        /// <returns>Filename prefix unique for SessioID</returns>
        public static string Prefix(SessionID sessionID)


This is mostly (or all) the same as FileStore.Prefix(). That was fine when they were small, but now I think this common code should be unified. Perhaps a static class & function would be appropriate?

I can do - should I put the new calls in "Util" subfolder of the solution?

That'll work, or it could go in the same dir as FileLog/FileStore. Doesn't really matter to me.

QuickFIXn/Session.cs

QuickFIXn/SessionSettings.cs

gbirchmeier · 2020-06-10T17:06:29Z

QuickFIXn/Session.cs

+        public Session(
+            IApplication app, IMessageStoreFactory storeFactory, SessionID sessID, DataDictionaryProvider dataDictProvider,
+            SessionSchedule sessionSchedule, int heartBtInt, ILogFactory logFactory, IMessageFactory msgFactory, string senderDefaultApplVerID,
+            IAcceptor acceptor, QuickFix.Dictionary settings)


I'm not terribly comfortable seeing _acceptor here given how this class isn't really acceptor-specific, but I don't have a better idea. Not totally sure about settings also.

Both _acceptor and _settings are required to create the new "real" session when connecting to a template session. However, as noted in the beginning, it may not be the best solution and might be replaced with adding a SessionTemplate class. What, in turn, then seemingly requires more changes to the logic of accepting connections and looking up existing sessions...

Yeah, I get that. I just don't like the resulting architecture. I'll think about it, see if any brainstorms come to me...

QuickFIXn/Session.cs

gbirchmeier · 2020-06-10T17:09:04Z

QuickFIXn/SessionSettings.cs

+                beginString != Values.WILDCARD_VALUE)
            {
-                throw new ConfigError(BEGINSTRING + " (" + beginString + ") must be FIX.4.0 to FIX.4.4 or FIXT.1.1");
+                throw new ConfigError($"{BEGINSTRING} ({ beginString }) must be FIX.4.0 to FIX.4.4 or FIXT.1.1 or wildcard '{Values.WILDCARD_VALUE}' (only for acceptor)");


How can we wildcard the begin string? An acceptor can only service one FIX version.

I got "inspired" by simpleacc.cfg, where one acceptor has several [SESSION] with different BeginString. Now, at second glance, I realize that DataDictionary needs to also be dynamically adjusted to BeginString, and that would probably be complicated to solve, but not really worth it... So I would agree to remove wildcard support for BeginString parameter.

QuickFIXn/Session.cs

UnitTests/SessionSettingsTest.cs

pvkv1799 · 2020-06-10T20:17:34Z

Ok, first off, this is going to have some conflicts with #609. That's not a big PR, but it does make a few changes to Session and SessionFactory. I hope to merge #609 today.

Fine, I will merge #609 into this PR as well (after you).

I'm not crazy about the acceptor-specific additions to Session. Can we think of any other approach? Making a DynamicSession subclass seems possible off the top of my head, but also could be horrible.

I did start with a new DynamicSession class but then realized that it would require more complicated changes than "simply" replacing LookupSession with LookupOrCreateSession (now called GetSession), so decided for a quicker solution.
I agree that this is (to a certain extent) a misuse of Session class, and could adjust the implementation following your architectural advice.

Don't go deep into any big changes yet. I also want to talk to @mgatny and see what ideas he has.

OK, I would wait for your further advice before making the suggested changes.

Thank you!

gbirchmeier · 2020-06-16T15:54:38Z

FYI, #609 is in master now, so at your leisure you can upmerge or rebase.

pvkv1799 · 2020-06-16T22:42:54Z

I understood that I should wait for decision on architecture - is the approach with passing acceptor into a session good enough? Or should it be changed, probably by adding a class for "template" session?

…

On Tue, 16 Jun 2020, 17:54 Grant Birchmeier, ***@***.***> wrote: FYI, #609 <#609> is in master now, so at your leisure you can upmerge or rebase. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#607 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKABHZT5FA7TSPBMOK4MIE3RW6IU5ANCNFSM4NR74BKA> .

gbirchmeier · 2020-06-17T13:36:56Z

Haven't had time to think about reworking the impl yet, but for now maybe just resolve the conflicts.

pvkv1799 · 2020-06-17T22:52:13Z

OK, will resolve

Catching up with the original master

pvkv1799 · 2020-06-18T21:34:11Z

Conflicts resolved, and some of the suggested fixes made (marked them resolved). The rest will do after decision on the architecture.
Thank you!

pvkv1799 · 2020-07-19T19:00:09Z

@gbirchmeier Apologies - have you had a chance to think about the architecture? I could do the changes if you have a better solution in mind.
Thank you!

connamara#466

…is not recognized as an internal or external command, operable program or batch file."

Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.16.1 to 3.17.0. - [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases) - [Commits](nunit/nunit3-vs-adapter@V3.16.1...V3.17) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

forgot to do this on 1.10.0 release, oops

connamara#630

2.7 is only on the VS2019 env, but appveyor is not letting me change to that env.

connamara#643

…ration string as a parameter instead of the hard-coded constant

Added wildcards validation into SessionSettings; Moved WILDCARD_VALUE from SessionSettings to Values; Added Unit Tests for wildcards for the recently changed classes

…incoming connection

CLAassistant · 2020-08-12T19:55:34Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ LittleAlexey
✅ pvkv1799
✅ gbirchmeier
❌ dependabot-preview[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

gbirchmeier requested changes Jun 10, 2020

View reviewed changes

gbirchmeier added the review in progress label Jun 10, 2020

Merge pull request #1 from connamara/master

0ac7ecc

Catching up with the original master

pvkv1799 force-pushed the wildcard_session branch from 2d4c15f to a63ffdc Compare June 18, 2020 20:51

LittleAlexey and others added 19 commits August 12, 2020 21:18

Logout can be received when not logged on.

1c0d3a6

connamara#466

Redirected stderr to stdout (nul) to avoid confusing message "'pwsh' …

4a32702

…is not recognized as an internal or external command, operable program or batch file."

comment about where pwsh comes from

31e4cd7

fix some typos

1aa5da1

don't use "./", don't auto-upload nugets

ab6d8c8

restore RELEASE-README.md... again

cabb0b8

fix formatting of RELEASE_README

37e4e3d

incremented version on release notes

7bce47e

forgot to do this on 1.10.0 release, oops

Don't reflect on non-QF/n assemblies

0ff6970

connamara#630

forgot to own it

5137896

corrections for ruby 2.5+; some script annotations

f92bc9f

remove old unused C++ build

505907a

use ruby 2.7 on appveyor

45dbc5d

some debugging for ruby on appveyor

9ae84bf

more debugging

ba756a2

change to ruby 2.6, since appveyor's being weird

737b728

2.7 is only on the VS2019 env, but appveyor is not letting me change to that env.

ignore .vscode/

243ddc4

add 1156 (ApplExtId) to FIXT11.xml

a0bdc64

connamara#643

gbirchmeier and others added 20 commits August 12, 2020 21:18

stupid copy/paste error in previous commit

edfffa3

connamara#643

Added "AcceptorTemplate" parameter

143da50

Comment

e3579b7

Added SessionID wildcards handling to FileLog

dc82d51

Added FileLog unit tests for wildcards

d296fcb

Refactored ThreadedSocketAcceptor unit tests: changed to pass configu…

acd35de

…ration string as a parameter instead of the hard-coded constant

Added SessionID wildcards handling to FileStore;

d0a14ee

Added wildcards validation into SessionSettings; Moved WILDCARD_VALUE from SessionSettings to Values; Added Unit Tests for wildcards for the recently changed classes

Bug fix: validation of BeginString regardless of Connection Type

622c395

Bug fix in test: wildcards are valid only for acceptor

782dfe3

Added logic to create the new session from a template upon receiving …

1eab2e4

…incoming connection

Added unit tests for dynamic session templates

52144b3

Removed unused AcceptorTemplate constant

56e5584

Documentation comments for GetSession

176dce3

Removed TODO from GetSession

6af399a

Added check for null _acceptor in CreateFromTemplate

3bb2a51

Improved explanations in comments

9059892

Using the new Session constructor with isInitiator

628b77a

Removed commented ACCEPTOR_TEMPLATE constant

50005cb

Renamed GetSession to LookupOrCreateDynamicSession

83f1b83

Removed commented-out irrelevant code

2f54fe5

pvkv1799 force-pushed the wildcard_session branch from 76b4b61 to 2f54fe5 Compare August 12, 2020 19:55

pvkv1799 mentioned this pull request Aug 16, 2020

Acceptor Dynamic Session Templates (2nd version) #650

Open

Conversation

pvkv1799 commented Jun 3, 2020

Uh oh!

gbirchmeier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pvkv1799 commented Jun 10, 2020

Uh oh!

gbirchmeier commented Jun 16, 2020

Uh oh!

pvkv1799 commented Jun 16, 2020 via email

Uh oh!

gbirchmeier commented Jun 17, 2020

Uh oh!

pvkv1799 commented Jun 17, 2020

Uh oh!

pvkv1799 commented Jun 18, 2020

Uh oh!

pvkv1799 commented Jul 19, 2020

Uh oh!

CLAassistant commented Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Aug 12, 2020 •

edited

Loading