Hovering over an icon shows it's name#126
Open
jacks-old-git wants to merge 1 commit intoconnors:masterfrom
jacks-old-git:patch-1
Open
Hovering over an icon shows it's name#126jacks-old-git wants to merge 1 commit intoconnors:masterfrom jacks-old-git:patch-1
jacks-old-git wants to merge 1 commit intoconnors:masterfrom
jacks-old-git:patch-1
Conversation
To more easily find the class name of an icon, you can now hover over it, and it will be displayed.
|
Can't people who want to find the class name just inspect it through the debug tools? Why add the class name to the title text indefinitely? If anything, you could omit the I just don't see how this is something that should be merged in? |
|
Though this would be useful for the getting started page on the website, not the actual library. Less troublesome for developers to go into their dev tools and find the name themselves, they could just hover instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To more easily find the class name of an icon, you can now hover over it, and it will be displayed. I understand that this doesn't strictly follow the guidelines for contributing, but I figured it was small enough that it's OK. If not, sorry.