-
Notifications
You must be signed in to change notification settings - Fork 0
[POC] Shaper based itemisation #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: icu4x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes most of the normalisation work from Parley
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file allow for shaped segments and holes to be stored in separate structures before deciding how they should be pushed to the Layout. I think a mature implementation will remove these temporary data structures and mutate Layout directly (to avoid redundant copies).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be ignored. By shaping with more fonts, the need to cache generating font metrics increases. So I added this LRU cache on font metrics to get a feel for what the ultimate performance of this approach could be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains a lot of refactoring and handling of shaped segments / holes.
See linebender#462 (comment)
To do: