Skip to content

fix: modify field name uniqueness constraint to only apply to UUID fields #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
Jan 7, 2026
+9 −3
Merged

fix: modify field name uniqueness constraint to only apply to UUID fields #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .../deploy/schemas/metaschema_public/tables/field/indexes/databases_field_uniq_names_idx.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ BEGIN;

CREATE UNIQUE INDEX databases_field_uniq_names_idx ON metaschema_public.field (
-- strip out any _id, etc., so that if you do create one and make foreign key relation, there is no conflict
table_id, DECODE(MD5(LOWER(regexp_replace(name, '^(.+?)(_row_id|_id|_uuid|_fk|_pk)$', '\1', 'i'))), 'hex')
-- only apply normalization to uuid fields (FK candidates) to avoid false collisions on text fields like current_role/current_role_id
table_id, DECODE(MD5(LOWER(
CASE
WHEN type = 'uuid' THEN regexp_replace(name, '^(.+?)(_row_id|_id|_uuid|_fk|_pk)$', '\1', 'i')
ELSE name
END
)), 'hex')
);

COMMIT;
4 changes: 2 additions & 2 deletions packages/metaschema-schema/sql/metaschema-schema--0.15.5.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ CREATE INDEX field_database_id_idx ON metaschema_public.field (database_id);

COMMENT ON COLUMN metaschema_public.field.default_value IS '@sqlExpression';

CREATE UNIQUE INDEX databases_field_uniq_names_idx ON metaschema_public.field (table_id, (decode(md5(lower(regexp_replace(name, '^(.+?)(_row_id|_id|_uuid|_fk|_pk)$', E'\\1', 'i'))), 'hex')));
CREATE UNIQUE INDEX databases_field_uniq_names_idx ON metaschema_public.field (table_id, (decode(md5(lower(CASE WHEN type = 'uuid' THEN regexp_replace(name, '^(.+?)(_row_id|_id|_uuid|_fk|_pk)$', E'\\1', 'i') ELSE name END)), 'hex')));

CREATE TABLE metaschema_public.foreign_key_constraint (
id uuid PRIMARY KEY DEFAULT uuid_generate_v4(),
Expand Down Expand Up @@ -579,4 +579,4 @@ COMMENT ON CONSTRAINT db_fkey ON metaschema_public.unique_constraint IS '@omit m

CREATE INDEX unique_constraint_table_id_idx ON metaschema_public.unique_constraint (table_id);

CREATE INDEX unique_constraint_database_id_idx ON metaschema_public.unique_constraint (database_id);
CREATE INDEX unique_constraint_database_id_idx ON metaschema_public.unique_constraint (database_id);