i have many problem with this. see README by Ethanng329 · Pull Request #4 · constructorlabs/delivereat

Ethanng329 · 2018-07-01T20:37:02Z

No description provided.

dmitrigrabov · 2018-07-20T10:09:20Z

index.js

+  orders[index] = req.body;
+  orders[index]['id'] = index;
+  orderid++;
+  res.status(200).json({ OK: 'order completed' });


It would be good to return the new object after save with new id

dmitrigrabov · 2018-07-20T10:10:01Z

index.js

+  res.json(orders);
+});
+
+// app.post('/menu', function(req, res) {


Commented out code can be removed

dmitrigrabov · 2018-07-20T10:13:22Z

index.js

+  res.status(200).json({ OK: 'order completed' });
+});
+
+app.get('/api/order', function(req, res) {


It could be better to call the route /api/orders as it returns multiple orders rather than a single order

dmitrigrabov · 2018-07-20T10:14:36Z

src/components/App.js

+      completeOrder: complete
+    });
+
+    fetch('http://localhost:8080/api/order', {


Use relative URL here - /api/order. It will also make the CORS issue go away

dmitrigrabov · 2018-07-20T10:15:08Z

src/components/App.js

+import Header from './Header';
+import Menu from './Menu';
+// import Basket from './Basket';
+import { METHODS } from 'http';


Is this import needed?

dmitrigrabov · 2018-07-20T10:15:25Z

src/components/App.js

 import React from 'react';
+import Header from './Header';
+import Menu from './Menu';
+// import Basket from './Basket';


Commented code can be removed

dmitrigrabov · 2018-07-20T10:16:10Z

src/components/App.js

+      const currentOrder = Object.assign({}, this.state.currentOrder, newOrder);
+      this.setState({ currentOrder });
+    } else if ((this.state.currentOrder[id] = 1)) {
+      const currentOrder = Object.assign({}, this.state.currentOrder);


dmitrigrabov · 2018-07-20T10:16:27Z

src/components/App.js

+  }
+
+  handleClick(event) {
+    // event.preventDefault()


Commented out code can be removed

dmitrigrabov · 2018-07-20T10:17:25Z

src/components/Basket.js

@@ -0,0 +1,13 @@
+import React from 'react';
+import { INSPECT_MAX_BYTES } from 'buffer';


Is this import needed?

dmitrigrabov · 2018-07-20T10:17:49Z

src/components/Menu.js

@@ -0,0 +1,37 @@
+import React from 'react';
+import { ENGINE_METHOD_DIGESTS } from 'constants';


Is this import needed?

dmitrigrabov · 2018-07-20T10:18:54Z

src/components/RegistrationForm.js

+
+    // dfads@asfdsd.com
+
+    const chunks = email.split('@');


It would be neat to extrac email validation function into own module. let me know if you need any help with that

dmitrigrabov · 2018-07-20T10:19:17Z

src/components/RegistrationForm.js

+            receiver={this.receiver}
+            value={this.state.email}
+          />
+          {/* <button type="submit">Submit</button> */}


Commented out code can be removed

dmitrigrabov · 2018-07-20T10:20:23Z

views/Successorder.hbs

@@ -0,0 +1,16 @@
+<!DOCTYPE html>


I would recommend naming this file using lower case

first attempt

5d5bfe5

dmitrigrabov reviewed Jul 20, 2018

View reviewed changes

index.js

res.json(orders);

});

// app.post('/menu', function(req, res) {

Copy link

Contributor

dmitrigrabov Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code can be removed

dmitrigrabov reviewed Jul 20, 2018

View reviewed changes

src/components/App.js Outdated

}

handleClick(event) {

// event.preventDefault()

Copy link

Contributor

dmitrigrabov Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code can be removed

dmitrigrabov reviewed Jul 20, 2018

View reviewed changes

views/Successorder.hbs

@@ -0,0 +1,16 @@

<!DOCTYPE html>

Copy link

Contributor

dmitrigrabov Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend naming this file using lower case

Ethanng329 added 16 commits August 21, 2018 10:28

refactored and changed a few spelling

ba73801

head reset

a4dbfaf

reseting head

e604e4a

node js changes

a10822d

route changed

6c1a785

handlebar path updated

ce22da5

script amended

d008376

added publicpath

ef2c71a

debugging

87ad221

fixing path

35e90e3

fixing path

40d5b0a

webpack changes

28a4e16

webpack updates

6447db1

path fixing

be2e45d

path fixing

3b944e8

defining handlebar type

73889af

Ethanng329 and others added 19 commits September 24, 2018 10:12

npm build run

531fcee

.

8b00349

added route

b97c17e

added path

dbd15fe

node updates

d132954

handle bar test

15ba93a

node updates

00c5a7e

node update

cdc5a15

merged

ad01906

remove bundle from gitignore

4b7ef0b

README updated

c6e465e

screenshot centered

768883b

README updates

c043a2a

update README link

517d141

added env info

fd10cb0

updated env info

19c5f97

updated changes

c0b8544

updates

f02e557

this should not be here, gitignore changed

f6b1405

		@@ -0,0 +1,13 @@
		import React from 'react';
		import { INSPECT_MAX_BYTES } from 'buffer';

		@@ -0,0 +1,37 @@
		import React from 'react';
		import { ENGINE_METHOD_DIGESTS } from 'constants';

Comments

Conversation

Ethanng329 commented Jul 1, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants