Open
Conversation
| <title>Responsive News Reader</title> | ||
| </head> | ||
|
|
||
| <body> |
Contributor
There was a problem hiding this comment.
It would be good to have indentation used here. It will make the HTML structure easier to read
| //TODO: stylization, excludeDomains/blocklist | ||
|
|
||
| //Object contains possible URLS for fetch requests | ||
| const apiRequests = { |
Contributor
There was a problem hiding this comment.
Very nice. I like how you have created an object that encapsulates all URL generation logic in one place
| }, | ||
|
|
||
| openCloseAdvanced: event => { | ||
| advancedSearchMenu.style.display === "none" |
Contributor
There was a problem hiding this comment.
This could rewritten slightly cleaner as
advancedSearchMenu.style.display = advancedSearchMenu.style.display === "none ? = "block" : "none"
|
|
||
| //creates each story panel from fetch response | ||
| function createStoryPanel(article){ | ||
| const storyDivElement = assignElement("div", "story-div-element") |
Contributor
There was a problem hiding this comment.
The logic here would be easier to implement as an HTML string template
|
|
||
|
|
||
| function fetchNews(apiAddress){ | ||
| fetch(apiAddress) |
Contributor
There was a problem hiding this comment.
nice. good to see how you pass in url as param and implement display logic in own function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like the apiRequests object and attached methods, think it will make it easy to add new functionality