Working version of News Reader#25
Open
NicolaGibson wants to merge 1 commit intoconstructorlabs:masterfrom
Open
Working version of News Reader#25NicolaGibson wants to merge 1 commit intoconstructorlabs:masterfrom
NicolaGibson wants to merge 1 commit intoconstructorlabs:masterfrom
Conversation
| button.setAttribute("href", article.url); | ||
| div.appendChild(button); | ||
|
|
||
| // function articleSearch() { |
Contributor
There was a problem hiding this comment.
Commented out code can be removed so it does not take up space on the page
| function displayData(articles) { | ||
| const stories = document.querySelector("#article"); | ||
| articles.map(article => { | ||
| let div = document.createElement("div"); |
Contributor
There was a problem hiding this comment.
It might easier to implement this part using HTML string templates
| @@ -0,0 +1,74 @@ | |||
| function displayData(articles) { | |||
| const stories = document.querySelector("#article"); | |||
| articles.map(article => { | |||
Contributor
There was a problem hiding this comment.
If you don't use the output of a map method, it's better to replace it with a forEach instead
| } | ||
|
|
||
| .wrapper { | ||
| display: grid; |
Contributor
There was a problem hiding this comment.
nice to see grid being used
Contributor
|
It would be great to see more frequent commits. Also, update the README at the end to explain what you have done. That will make it easier to for reviewer to see what you have built. Also, potential employers might take a look at the README in future and an explanation of project will help them to understand what you can do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.