Skip to content

Conversation

@austinvazquez
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 12, 2025 02:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new integration test job to the CI workflow to improve test coverage by running integration tests in the build pipeline.

Key changes:

  • Added a new integration job to the GitHub Actions workflow
  • Configured the job to build the project and run integration tests using Go

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch 2 times, most recently from 48a516c to 0e0ef9f Compare December 15, 2025 14:32
Copilot AI review requested due to automatic review settings December 15, 2025 14:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from 0e0ef9f to ea4838d Compare December 15, 2025 14:35
Copilot AI review requested due to automatic review settings December 15, 2025 14:37
@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from ea4838d to 84890ed Compare December 15, 2025 14:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from 84890ed to a7e64a6 Compare December 15, 2025 17:01
Copilot AI review requested due to automatic review settings December 15, 2025 23:22
@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from a7e64a6 to 31f586d Compare December 15, 2025 23:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from 31f586d to 8a9ee83 Compare December 15, 2025 23:24
Copilot AI review requested due to automatic review settings December 16, 2025 14:40
@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from 8a9ee83 to 1af3e23 Compare December 16, 2025 14:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shell: bash
run: |
# Hash the kernel config and patches to create a unique cache key
CONFIG_FILE="kernel/config-${{ inputs.kernel_version }}-${{ inputs.kernel_arch }}"
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config file path is missing the .config extension. Based on the integration test workflow that uses CONFIG_FILE=\"kernel/config-${{ needs.setup.outputs.kernel_version }}-${{ env.ARCH }}.config\", this should be kernel/config-${{ inputs.kernel_version }}-${{ inputs.kernel_arch }}.config.

Suggested change
CONFIG_FILE="kernel/config-${{ inputs.kernel_version }}-${{ inputs.kernel_arch }}"
CONFIG_FILE="kernel/config-${{ inputs.kernel_version }}-${{ inputs.kernel_arch }}.config"

Copilot uses AI. Check for mistakes.
@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from 1af3e23 to f6a5b11 Compare December 16, 2025 14:56
Copilot AI review requested due to automatic review settings December 16, 2025 17:51
@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from f6a5b11 to 8a835c3 Compare December 16, 2025 17:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from 8a835c3 to 991c714 Compare December 16, 2025 18:16
Copilot AI review requested due to automatic review settings December 16, 2025 18:22
@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from 991c714 to a041e1f Compare December 16, 2025 18:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from a041e1f to 9e58257 Compare December 16, 2025 18:31
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
@austinvazquez
Copy link
Member Author

Downgrade to 6.12.44 (from #74)

Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Copilot AI review requested due to automatic review settings December 16, 2025 22:30
@austinvazquez austinvazquez force-pushed the add-integration-test-to-ci branch from 9e58257 to 8a0a1fc Compare December 16, 2025 22:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +25 to +27
OS ?= $(shell uname -s | tr '[:upper:]' '[:lower:]')
ARCH ?= $(shell uname -m)
export PLATFORM ?= $(OS)/$(ARCH)
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name OS may conflict with environment variables or built-in variables in some shells. Consider renaming it to HOST_OS for clarity and consistency with the HOST_OS variable used in the docker-bake.hcl file.

Suggested change
OS ?= $(shell uname -s | tr '[:upper:]' '[:lower:]')
ARCH ?= $(shell uname -m)
export PLATFORM ?= $(OS)/$(ARCH)
HOST_OS ?= $(shell uname -s | tr '[:upper:]' '[:lower:]')
ARCH ?= $(shell uname -m)
export PLATFORM ?= $(HOST_OS)/$(ARCH)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant