image: Add buildSignerURI for Fulcio workflow identity verification#625
Open
abyrne55 wants to merge 1 commit intocontainers:mainfrom
Open
image: Add buildSignerURI for Fulcio workflow identity verification#625abyrne55 wants to merge 1 commit intocontainers:mainfrom
abyrne55 wants to merge 1 commit intocontainers:mainfrom
Conversation
Add support for verifying Sigstore signatures from CI workflows (e.g.,
GitHub Actions) by matching on the Fulcio BuildSignerURI certificate
extension (OID 1.3.6.1.4.1.57264.1.9).
This addresses a gap where keyless Sigstore signatures created by
automated CI workflows could not be verified via policy.json, since
the existing subjectEmail field only matches email-based identities
from interactive signing.
The new buildSignerURI field:
- Extracts from the specific OID, not the SAN URI (avoiding ambiguity)
- Uses exact string matching (no substring or regex)
- Follows existing code patterns for OID extraction
Example policy.json configuration:
"fulcio": {
"caPath": "/etc/pki/containers/fulcio.sigstore.dev.pub",
"oidcIssuer": "https://token.actions.githubusercontent.com",
"buildSignerURI": "https://github.com/org/repo/.github/workflows/release.yml@refs/heads/main"
}
Closes: containers#34
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Anthony Byrne <abyrne@redhat.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for verifying Sigstore signatures from CI workflows (e.g., GitHub Actions) by matching on the Fulcio
BuildSignerURIcertificate extension (OID1.3.6.1.4.1.57264.1.9).This addresses a gap where keyless Sigstore signatures created by automated CI workflows could not be verified via
policy.json, since the existingsubjectEmailfield only matches email-based identities from interactive signing.Closes #34
Security Model
What does a signature with
buildSignerURIprove?A valid signature means:
https://token.actions.githubusercontent.com) authenticated the signerBuildSignerURIextension (Fulcio OID 1.3.6.1.4.1.57264.1.9) matches the policy-specified workflow URI exactlyThis allows policies like: "Accept images signed by the
release.ymlworkflow inmyorg/myrepoon themainbranch, authenticated via GitHub Actions OIDC."Design Decisions
BuildSignerURIOID is semantically unambiguous.fulcioBuildSignerURIInCertificatemirrorsfulcioIssuerInCertificatefor consistency.Example Configuration
{ "type": "sigstoreSigned", "fulcio": { "caPath": "/etc/pki/containers/fulcio.sigstore.dev.pub", "oidcIssuer": "https://token.actions.githubusercontent.com", "buildSignerURI": "https://github.com/myorg/myrepo/.github/workflows/release.yml@refs/heads/main" }, "rekorPublicKeyPath": "/etc/pki/containers/rekor.sigstore.dev.pub", "signedIdentity": {"type": "matchRepository"} }Testing
fulcioBuildSignerURIInCertificate(valid extraction, missing extension, duplicate extension, invalid ASN.1)fulcioTrustRoot.validate()with new field combinationsbuildSignerURIbuildSignerURImatching/mismatchingRelated