libimage: treat localhost/ images as local-only#660
Closed
mehrdadbn9 wants to merge 2 commits intocontainers:mainfrom
Closed
libimage: treat localhost/ images as local-only#660mehrdadbn9 wants to merge 2 commits intocontainers:mainfrom
mehrdadbn9 wants to merge 2 commits intocontainers:mainfrom
Conversation
Images prefixed with "localhost/" (without a port number) are a naming convention for local-only images in Podman/Buildah. They should never attempt a network pull from a Docker registry. Previously, when building an image with "FROM localhost/base-toolbox:latest" in a Containerfile, podman would attempt to pull from docker://localhost/base-toolbox:latest, which fails because localhost is not a real Docker registry. This fix adds a check in copySingleImageFromRegistry to detect localhost/ prefixed image names and return the local image if found, or an error if not found, without ever attempting a network pull. Fixes: containers/podman#28038 Signed-off-by: mehrdadbn9 <mehrdadbiukian@gmail.com>
Images prefixed with "localhost/" (without a port number) are a naming convention for local-only images in Podman/Buildah. They should never attempt a network pull from a Docker registry. Previously, when building an image with "FROM localhost/base-toolbox:latest" in a Containerfile, podman would attempt to pull from docker://localhost/base-toolbox:latest, which fails because localhost is not a real Docker registry. This fix adds a check in copySingleImageFromRegistry to detect localhost/ prefixed image names and return the local image if found, or an error if not found, without ever attempting a network pull. Fixes: containers/podman#28038 Signed-off-by: mehrdadbn9 <mehrdadbiukian@gmail.com>
mtrmac
requested changes
Feb 12, 2026
Contributor
mtrmac
left a comment
There was a problem hiding this comment.
I didn’t investigate this myself, but at a glance this looks unlikely to be correct.
The reports say that this worked until recently, and this kind of code was not necessary. What has changed and why is extra condition the right approach?
There’s also containers/podman#28038 (comment) saying that localhost/ is not the point, and similarly containers/podman#28038 (comment) .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where images prefixed with
localhost/(without a port) were incorrectly treated as remote Docker registry references, causingpodman buildto fail with:Problem
Images named with
localhost/prefix (e.g.,localhost/base-toolbox:latest) are a naming convention for local-only images in Podman/Buildah. They should never attempt a network pull from a Docker registry.Previously, when building an image with
FROM localhost/base-toolbox:latestin a Containerfile, the code would:neweroralways, attempt to pull fromdocker://localhost/base-toolbox:latestlocalhostwithout a port is not a real Docker registrySolution
Added a check in
copySingleImageFromRegistry()to detectlocalhost/prefixed image names (without a port) and:storage.ErrImageUnknownif not foundThis prevents any network pull attempts for localhost images.
Testing
The fix can be verified by:
localhost/base:latestFROM localhost/base:latestin its ContainerfileFixes: containers/podman#28038