Closed
Conversation
Staging -> Main
Staging --> Main
Signed-off-by: Amitkanswal <amitkanswal7@gmail.com>
rijil-tr
requested changes
Jun 25, 2025
rijil-tr
requested changes
Jul 14, 2025
| return { | ||
| __isPluginBuilder__: true, | ||
| version, | ||
| plugins: (context: InitializationData, rte: IRteParam) => { |
There was a problem hiding this comment.
Why do we need to use the broader type here when we know we are getting RTE specific initialization data?
| this._config.elementType = elementType; | ||
| return this; | ||
| } | ||
| render(renderFn: (element: React.ReactElement, attrs: { [key: string]: any }, path: number[], rte: IRteParam) => React.ReactElement): PluginBuilder { |
There was a problem hiding this comment.
Below is the signature of existing render function
render?: (...params: any) => ReactElementWhy are we introducing additional arguments now? Why these issues not occurring with existing plugins?
| const plugins = async (context: InitializationData, rte: IRteParam) => { | ||
| try { | ||
| const sdk = new UiLocation(context); | ||
| console.log("sdk", sdk); |
| | "GCP_NA" | ||
| | string; | ||
|
|
||
| export type Extension = { |
Contributor
Author
There was a problem hiding this comment.
I will resolve this
| this.modal = new Modal(); | ||
|
|
||
| this.region = formatAppRegion(initializationData.region); | ||
| this.region = formatAppRegion(initializationData.region as Region); |
There was a problem hiding this comment.
Why are we using Region here? region is of type RegionType right?
Contributor
Author
There was a problem hiding this comment.
this is the older version PR changes for region is present in develop branch
Contributor
Author
There was a problem hiding this comment.
I will create a new pr and close this one
| } | ||
|
|
||
| export function formatAppRegion(region: string): RegionType { | ||
| return region ?? Region.UNKNOWN; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes- support for new JSON RTE plugin