Closed
Conversation
Contributor
harshithad0703
commented
Feb 14, 2025
harshithad0703
commented
- refactor: update uid validation to use static regex and switch to HTTPS server
aman19K
reviewed
Feb 17, 2025
| return new Promise((resolve, reject) => { | ||
| try { | ||
| const server = http.createServer((req, res) => { | ||
| const server = https.createServer((req, res) => { |
Contributor
There was a problem hiding this comment.
@harshithad0703 ,We can't use HTTPS in the CLI because the server is hosted on the client side, so it's not possible. Pls check with @cs-raj regarding this.
aman19K
reviewed
Feb 17, 2025
Comment on lines
+210
to
+212
| // Use a static regex for alphanumeric only uids | ||
| const uidRegex = /^[a-zA-Z0-9]+$/; // Static regex that matches alphanumeric uids | ||
| if (uid.match(uidRegex)) { // Validate against the static regex |
Contributor
There was a problem hiding this comment.
@harshithad0703 , pls check with @cs-raj. Both issues we can't fix.
cs-raj
force-pushed
the
fix/dx-2188-sre-semgrep
branch
from
5566ed6 to
f9de428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.