This repository was archived by the owner on May 19, 2025. It is now read-only.
Support for node 18 & removed dependency of Preview Host.#66
Closed
Contentstack-AnkitaD wants to merge 3 commits intomasterfrom
Closed
Support for node 18 & removed dependency of Preview Host.#66Contentstack-AnkitaD wants to merge 3 commits intomasterfrom
Contentstack-AnkitaD wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
|
We NO MORE need this work-around logic, hence closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR updates the
contentstack-angular-startermaster branch to make it production-ready for Marketplace deployment with Live Preview support.✅ Key Changes
Live Preview Optimization:
preview_hostis now dynamically derived fromCONTENTSTACK_APP_HOSTif not explicitly set.Updated
.env.samplewith necessary Live Preview environment variables:CONTENTSTACK_PREVIEW_TOKENCONTENTSTACK_APP_HOSTCONTENTSTACK_LIVE_PREVIEWNode Version Update:
package.jsonto require Node>=18.0.0to match deployment compatibility.Environment Config Enhancements:
setenv.tsto generatepreview_hostfromapp_host.branchandregionif not provided.🔒 Talisman Update
.env.sampleandsetenv.tsto.talismanrcwith respective SHA checksums to avoid false positives during secret scans.🗂️ Files Modified
.env.samplepackage.jsonsetenv.ts.talismanrcpackage-lock.json🎯 Purpose
To ensure the Angular starter master branch works seamlessly with Marketplace deployment and supports secure Live Preview integration without relying on the management token.