used marketplaceSDK instead of managementSDK for app related operations#377
Merged
naman-contentstack merged 11 commits intodevelopmentfrom Jul 21, 2025
Merged
used marketplaceSDK instead of managementSDK for app related operations#377naman-contentstack merged 11 commits intodevelopmentfrom
naman-contentstack merged 11 commits intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates app-related operations from using the managementSDK to the marketplaceSDK, aligning with the expected SDK for handling app installations and management operations. The changes include updating imports, function signatures, and test stubs to support the new SDK architecture.
Key changes:
- Replace managementSDK with marketplaceSDK for app installation and lifecycle operations
- Update imports from
@contentstack/managementto@contentstack/marketplace-sdk - Refactor test files to remove duplicate stubs and improve test reliability
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/common-utils.ts | Updated app installation and update functions to use marketplaceSDK |
| src/util/inquirer.ts | Modified app installation queries and added marketplace SDK support |
| src/commands/app/*.ts | Updated command implementations to use marketplaceSDK for app operations |
| src/strategies/*.ts | Updated uninstall strategies to support marketplaceSDK parameter passing |
| test/unit/commands/app/*.ts | Removed duplicate test stubs and improved test setup |
| package.json | Updated CLI utilities dependency version |
Comments suppressed due to low confidence (3)
test/unit/commands/app/update.test.ts:49
- This test has duplicate loader stubs - one was removed from line 48 but another remains. The remaining stub on line 49 should be sufficient.
sandbox.stub(cliux, "loader").callsFake(() => {});
test/unit/commands/app/uninstall.test.ts:113
- The test expects an error exit code but no longer validates it after removing the error assertion. Consider verifying the command still handles the error appropriately.
const { stdout } = await runCommand([
test/unit/commands/app/reinstall.test.ts:182
- The test changed from using mock.apps[0] to mock.apps[1] without explanation. This could indicate a test dependency issue or missing test data validation.
App: mock.apps[1].name,
aman19K
requested changes
Jul 17, 2025
aman19K
approved these changes
Jul 17, 2025
aman19K
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor version bump 1.5.1 -> 1.6.0