fix for sync method not working correctly#141
Merged
nadeem-cs merged 4 commits intocontentstack:developmentfrom Mar 11, 2025
Merged
fix for sync method not working correctly#141nadeem-cs merged 4 commits intocontentstack:developmentfrom
nadeem-cs merged 4 commits intocontentstack:developmentfrom
Conversation
Contributor
|
Thanks for the contribution! @erikpost |
Contributor
Author
|
@nadeem-cs thanks for taking a look at this PR. I've updated the base branch to |
nadeem-cs
approved these changes
Mar 11, 2025
Contributor
Author
|
@nadeem-cs when will this be released in a new version of the typescript SDK? would be great if we can remove the workaround from our own code and use an SDK version with the fix. |
Contributor
|
@erikpost This will be released by next week. I will update here as soon as its released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't get the sync method working, so I took a look and noticed two issues: