dx | 3186 | Exception during sync#65
Merged
harshithad0703 merged 1 commit intodevelopmentfrom Jun 26, 2025
Merged
Conversation
…lesystem operations.
aman19K
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors filesystem operations to use the built-in recursive mkdirSync in place of the external mkdirp package for creating directories when needed during sync operations. Key changes include:
- Removing the mkdirp dependency and using fs.mkdirSync with the recursive option.
- Updating code in multiple files (src/util/index.ts, src/util/fs.ts, and src/fs.ts) to reflect this change.
- Bumping the package version and updating checksum values in .talismanrc.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/index.ts | Replace mkdirp.sync with fs.mkdirSync(..., { recursive: true }) |
| src/util/fs.ts | Replace mkdirp.sync with fs.mkdirSync(..., { recursive: true }) |
| src/fs.ts | Adding recursive flag to mkdirSync calls for directory creation |
| package.json | Updated package version |
| .talismanrc | Updated checksum for package-lock.json entry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor mkdirSync usage to ensure recursive directory creation in filesystem operations.