Skip to content

dx | 3186 | Exception during sync#65

Merged
harshithad0703 merged 1 commit intodevelopmentfrom
fix/dx-3186-exception-during-sync
Jun 26, 2025
Merged

dx | 3186 | Exception during sync#65
harshithad0703 merged 1 commit intodevelopmentfrom
fix/dx-3186-exception-during-sync

Conversation

@harshithad0703
Copy link
Contributor

refactor mkdirSync usage to ensure recursive directory creation in filesystem operations.

@harshithad0703 harshithad0703 requested a review from a team as a code owner June 26, 2025 10:33
@harshithad0703 harshithad0703 requested review from Copilot and removed request for a team June 26, 2025 10:40

This comment was marked as outdated.

@harshithad0703 harshithad0703 requested a review from Copilot June 26, 2025 11:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors filesystem operations to use the built-in recursive mkdirSync in place of the external mkdirp package for creating directories when needed during sync operations. Key changes include:

  • Removing the mkdirp dependency and using fs.mkdirSync with the recursive option.
  • Updating code in multiple files (src/util/index.ts, src/util/fs.ts, and src/fs.ts) to reflect this change.
  • Bumping the package version and updating checksum values in .talismanrc.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/util/index.ts Replace mkdirp.sync with fs.mkdirSync(..., { recursive: true })
src/util/fs.ts Replace mkdirp.sync with fs.mkdirSync(..., { recursive: true })
src/fs.ts Adding recursive flag to mkdirSync calls for directory creation
package.json Updated package version
.talismanrc Updated checksum for package-lock.json entry

@harshithad0703 harshithad0703 merged commit 99b0b7d into development Jun 26, 2025
9 checks passed
@cs-raj cs-raj deleted the fix/dx-3186-exception-during-sync branch June 26, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants