Error handling for creating new GitHub projects, Support for validating git remote url for SSH format and update version in package.json file #52
Merged
Chhavi-Mandowara merged 2 commits intostagingfrom May 6, 2025
Conversation
fix: allow --type flag to create new project without prompting to select provider
tejas-contentstack
approved these changes
May 6, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling for creating new GitHub projects, adds support for validating git remote URLs in SSH format, and updates the version in package.json.
- Refactors provider type selection by replacing a direct call to selectProjectType with a new helper, setProviderType.
- Improves error handling and validates input flags to streamline project creation.
- Updates test cases to account for the new --type flag behavior.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/commands/launch/index.ts | Refactor to use setProviderType for provider handling and adjust inline command examples. |
| src/commands/launch/index.test.ts | Adds a new test to verify that passing the provider flag bypasses prompting. |
Files not reviewed (1)
- .talismanrc: Language not supported
Comments suppressed due to low confidence (1)
src/commands/launch/index.test.ts:118
- The test expects 'prepareApiClientsMock' and 'preCheckRunMock' to be called, but their initialization is not shown in the diff. Ensure these spies are properly set up so the test accurately verifies the behavior.
expect(prepareApiClientsMock).toHaveBeenCalled();
naeem-shakh-cs
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: allow --type flag to create new project without prompting to select provider
fix: error handling for creating new GitHub projects
fix: support validating git remote url for SSH format
chore: update version in package.json file