fix: use runtime cwd for data-dir flag#90
Merged
Harshi-Shah-CS merged 1 commit intodevelopmentfrom Jan 28, 2026
Merged
Conversation
Chhavi-Mandowara
previously approved these changes
Jan 28, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the data-dir flag's default value was captured at module load time instead of at runtime. The change ensures that process.cwd() is evaluated when the command executes, not when the module is loaded.
Changes:
- Removed the
default: process.cwd()from thedata-dirflag definition in theFunctionscommand - Added runtime evaluation of
process.cwd()in theinit()method with fallback logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Harshi-Shah-CS
force-pushed
the
cl-2273
branch
from
b537b20 to
5da501a
Compare
Harshi-Shah-CS
requested review from
a team,
Chhavi-Mandowara and
dhruvparekh12
Chhavi-Mandowara
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: use runtime cwd for data-dir flag