Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses a bug (CMG-771) where the cross icon (clear button) was missing from the text box when selecting a field from multiple matches, and includes package upgrades for various @contentstack CLI packages.
Changes:
- Fixed the
isClearablelogic to show the clear button based on whether a field has a label rather than type matching - Simplified content type change handling to clear all field mappings instead of attempting to preserve them
- Updated @contentstack CLI packages from version 1.5x.x to 1.55.0-1.17.0 range and related dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/src/components/ContentMapper/index.tsx | Fixed isClearable condition for the clear icon, added guard condition to prevent updates during content type changes, and simplified field mapping logic when content types are switched |
| api/package-lock.json | Updated @contentstack CLI package versions, improved dependency declarations for @contentstack/cli-variants, and included various transitive dependency updates (ws, emoji-regex, iconv-lite, TypeScript, rollup, etc.) |
Files not reviewed (1)
- api/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
umeshmore45
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains :
CMG-771 - Existing stack -> Existing content type is selected -> when 2 matches found for a field and from that 1 is selected , cross icon is missing in text box