feat(Visualizations): Axis styling #178
Conversation
|
@ImogenF can you please add separate story (to storybook) which will showcase all capabilities of Axis? |
|
I guess out of scope of this PR: |
|
The previous state was also not great: In this case, the user (or the Explore UI by default) should configure the value of
|
Missed this one yesterday. You're right, out of scope and I'm not sure if there's a nice solution for this one. We could allow the user to change the font size perhaps, but either way, there is bound to be some label overlap sometimes - I think it will have to be up to the user whether they want to display labels at all in that case. |
|
@ImogenF this PR needs rebase |
ImogenF
force-pushed
the
EX-116-axis-styling
branch
from
7ba85d3 to
b963e6a
Compare
| let text = textEl.text(); | ||
| let width = (textEl.node() as Element).getBoundingClientRect().width; | ||
| while (width > maxWidth && text.length > 0) { | ||
| text = text.slice(0, -1); |
There was a problem hiding this comment.
Calculate size through getBoundingClientRect is expensive operation. We can use "binary search" here
Improved colours etc.
Truncated axis labels where necessary.
Fixed
maxNumberOfTicksbehaviour.