fix: fix slice init length #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cuishuang <imcusg@gmail.com>
Author
|
@coocood Hi, could you please review this PR? Thank you! |
Owner
|
The intension is initializing the length, or the test would fail. |
|
you are right here, but not right to the context of the ring buffer, when the ring buffer tries to set a segment a value, they store the length not the capacity of the object and the capacity of the object is not concerned with the implementation for several reasons, so TLDR: the capacity is ignored and the length is the actual matter attribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here should be to initialize a slice with a capacity of len(staffCustomerIDs) rather than initializing the length of this slice.
The online demo: https://go.dev/play/p/q1BcVCmvidW