Simplies logic to just forward to other methods, makes stats tracking consistent. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deckarep
commented
Oct 17, 2018
deckarep
commented
- Simplifying logic that's duplicated
- Makes stats consistent with how they're getting cleared and locates them to a single method.
…nt where some weren't being fully cleared
coocood
reviewed
Oct 17, 2018
segment.go
Outdated
| atomic.StoreInt64(&seg.missCount, 0) | ||
| atomic.StoreInt64(&seg.overwrites, 0) | ||
| atomic.StoreInt64(&seg.totalCount, 0) | ||
| atomic.StoreInt64(&seg.totalTime, 0) |
Owner
There was a problem hiding this comment.
totalTime and totalCount is not stats.
Owner
There was a problem hiding this comment.
When Cache.ResetStatistics is called, we don't want to change them.
Contributor
Author
There was a problem hiding this comment.
Ok, thanks for pointing that out. I will follow up with a fix.
Contributor
Author
|
@coocood - ok, finally got around to making the change. Please review and thank you. |
coocood
reviewed
Oct 27, 2018
| atomic.StoreInt64(&seg.totalEvacuate, 0) | ||
| atomic.StoreInt64(&seg.totalExpired, 0) | ||
| atomic.StoreInt64(&seg.overwrites, 0) | ||
| atomic.StoreInt64(&seg.entryCount, 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.