Conversation
91313ad to
bd618ec
Compare
|
Can I get an extra quick assessment about dashes versus underscores in the output variable name? I see that the neighboring |
Yeah, maybe copying |
bd618ec to
8907576
Compare
Invalidated by push of 8907576
Adds an output that indicates whether an image was pushed. Dependant workflows can use this output to evaluate whether they should conditionally execute deployment or other downstream actions based on whether image building occurred. Changes: - Add oci-image-pushed output to mage.yaml - Add oci-image-pushed output to goapp.yaml and reusable-goapp.yaml - Set output based on presence of var/oci-images.json file
8907576 to
beec508
Compare
|
Yeah this would be an good idea i guess. But this one lines would do the same if i am correct if: github.ref == 'refs/heads/main' && needs.mage.outputs.oci-images != ''https://github.com/coopnorge/customer-order-management/blob/main/.github/workflows/cicd.yaml#L76 |
|
Either way is fine with me, I think mine seems more intuitive, on the other hand the customer-order-management version already works with the status quo |
Adds an output that indicates whether an image was pushed.
Dependant workflows can use this output to evaluate whether they should
conditionally execute deployment or other downstream actions based on
whether image building occurred.
Changes: