fix: Always use repo root as cwd when running tflint#498
Draft
AtzeDeVries wants to merge 5 commits intomainfrom
Draft
fix: Always use repo root as cwd when running tflint#498AtzeDeVries wants to merge 5 commits intomainfrom
AtzeDeVries wants to merge 5 commits intomainfrom
Conversation
Using the current pwd as basepath seems to mess up when running on mac when tflint is running in docker. This dir is intended to be the root of the repo so using the `GetRepoRoot` is a safe approach. Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
Signed-off-by: Atze de Vries <atze.wiebe.de.vries@coop.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the current pwd as basepath seems to mess up when running on mac when tflint is running in docker. This dir is intended to be the root of the repo so using the
GetRepoRootis a safe approach.