disk_1308 nlc-- double decrement 0->ff fix #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running QEMU and requesting geometry with CYL=1 it would return 0xff instead of 0.
BOCHS returns 0 as expected.
I have put [if] in case it is something important to have at least a zero check condition. But is it that important to have "1 reserverd" in an emulator?
Running bochs:
ata0-master: type=disk, path="\wsl.localhost\Debian\home\user\devel\os64\build\boot.img", cylinders=1, heads=1, spt=26
boot: disk
Running qemu:
qemu-system-x86_64.exe -device ide-hd,bus=ide.0,drive=disk0,cyls=1,heads=1,secs=26,bios-chs-trans=none -drive if=none,format=raw,id=disk0,file=\wsl.localhost\Debian\home\user\devel\os64\build\boot.img