Improve k8s_setup.sh debugging #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarathene
reviewed
Nov 7, 2025
Comment on lines
+18
to
+19
| out=$(kubectl get nodes -o jsonpath="$JSONPATH") | ||
| echo "${out}" |
Contributor
There was a problem hiding this comment.
This probably would have made it clear why this failure occurred (kubectl was XML instead of a binary which caused a 10m timeout failure)
polarathene
reviewed
Nov 8, 2025
Comment on lines
+14
to
+18
| JSONPATH='{range .items[*]}{@.metadata.name}:{range @.status.conditions[*]}{@.type}={@.status};{end}{end}' | ||
| out='' | ||
| until [[ "${out}" =~ 'Ready=True' ]]; do | ||
| sleep 1 | ||
| out=$(kubectl get nodes -o jsonpath="$JSONPATH") |
Contributor
There was a problem hiding this comment.
I saw here a better alternative for this logic?
echo "Waiting for cluster to be ready"
kubectl wait --for=condition=Ready nodes --all --timeout=60s >/dev/null 2>&1AFAIK that is performing the same query? There script likewise calls kind create cluster just prior to this, but inlines a custom config:
echo "Creating Kind Cluster"
cat <<EOF | kind create cluster --config=- || exit 1
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
image: kindest/node:v${VERSION}
extraPortMappings:
- containerPort: 80
hostPort: 80
protocol: TCP
- containerPort: 443
hostPort: 443
protocol: TCP
EOF
Contributor
Author
There was a problem hiding this comment.
Oh, that is better, thanks for the tip.
Contributor
There was a problem hiding this comment.
FWIW I already raised a PR for that change alone given the age of this PR 😅 (which doesn't inspire much hope for the PRs I raised for the CI to get merged)
* Don't hide kubectl stderr. * Print output of kubectl node status. * Use `/usr/bin/env` to access bash for improved platform comaptibility. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/debug_k8s_setup
branch
from
383724b to
610a7ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/bin/envto access bash for improved platform comaptibility.