Skip to content

Conversation

@bbbco
Copy link
Contributor

@bbbco bbbco commented Apr 28, 2025

Fixes this issue by allowing the getPageFilePath() to always run against all assets, and allows it to determine if it needs to add the .html extension or not based on the construction of the URL.

@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.35%. Comparing base (137bf38) to head (4834fb6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
scraper/download.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   47.55%   47.35%   -0.21%     
==========================================
  Files          14       14              
  Lines        1024     1022       -2     
==========================================
- Hits          487      484       -3     
- Misses        485      486       +1     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cornelk
Copy link
Owner

cornelk commented Jul 20, 2025

@bbbco thank you for the contribution, unfortunately the parameter isAPage can not be removed as this will break existing functionality. I updated the main branch code with comments to explain the need for this parameter better.

@cornelk cornelk closed this Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants