fix: One size calculation to address various FOV issues. #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayfarer3130
commented
Jan 6, 2026
| viewUp, | ||
| viewPlaneNormal | ||
| )); | ||
| const extent = imageData.getExtent(); |
Collaborator
Author
There was a problem hiding this comment.
The rest of this code is just temporary to show that the width world/height world are nearly exactly the same as the preivous calculation.
wayfarer3130
commented
Jan 6, 2026
| '1.3.6.1.4.1.14519.5.2.1.7009.2403.334240657131972136850343327463', | ||
| SeriesInstanceUID: | ||
| '1.3.6.1.4.1.14519.5.2.1.7009.2403.226151125820845824875394858561', | ||
| StudyInstanceUID: '1.3.6.1.4.1.25403.345050719074.3824.20170125095438.5', |
Collaborator
Author
There was a problem hiding this comment.
Use a better example of a non-cube volume to show sizing of volumes.
Collaborator
Author
|
@tblock79 and @IbrahimCSAE - does this PR address your concerns? I know it doesn't yet pass quite all the tests, still need to update a few, but it is mostly compatible as well as working correctly for multiple view orientations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In CS3D 4.0, there was a change to update the size of the image area to use just the width/height. That contained a few bugs causing the sizing of some images to fail to be correct, but there are a lot of tests looking at the exact size.
This PR is compatible with that change for all stack views, but uses the correct sizing/location for MPR views.
Changes & Results
Distort the correct positioning just a tiny bit to agree with the new full-view display, but otherwise just use a single view calculation for displaying the image data.
Testing
Run
bun example resize
Turn off the "store Display Area" (it causes some problems when switching stored display areas - it can otherwise be used)
Use the various display areas to show the image in various locations/sizes - by default, the image should just touch the edges - this is incorrect by up to 2 pixels in a few cases.
Addresses: [#2317]
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment