Skip to content

Conversation

@nithin-trenser
Copy link
Contributor

Context

This PR resolves image shifting in MPR viewports when loading or selecting measurements. This issue was observed with multiframe datasets.

Fixes: OHIF/Viewers#5684

This PR has been incorporated by FlyWheel.io

Changes & Results

The setViewPlane() method was updated to accept a referenceImageId and pass it to setViewReference() during invocation.

Before:

mpr-image-shift-bug.mp4

After:

fix-mpr-image-shift-bug.mp4

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11 10.0.22631
  • Node version: 20.17.0
  • Browser: Chrome: 143.0.7499.170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Image shift in MPR viewports when selecting measurements.

1 participant