Feature/ rotate clipping planes in volume cropping tool #2547
+2,118
−1,750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… orientation based on image orientation patient values
…e functionality and UI improvements - Updated the volume cropping tool to include toggles for clipping planes and handles. - Improved instructions for user interaction with clipping planes. - Added new utility functions for handling clipping planes, including copying and calculating adaptive sphere radius. - Introduced constants for clipping plane indices and tolerances. - Enhanced the tool's ability to handle rotated volumes and maintain proper clipping plane orientation. - Added new utility functions for line intersection and color conversion. - Refactored existing code for better clarity and maintainability.
…Orientation function and its documentation
…larity in clipping plane updates
igoroctaviano
suggested changes
Jan 9, 2026
Contributor
igoroctaviano
left a comment
igoroctaviano
left a comment
There was a problem hiding this comment.
LGTM, left one comment
| // Call setHandlesVisible on the tool instance | ||
| if (croppingTool && typeof croppingTool.setHandlesVisible === 'function') { | ||
| croppingTool.setHandlesVisible(!croppingTool.getHandlesVisible()); | ||
| // Call setClippingPlanesVisible on the tool instance |
Contributor
There was a problem hiding this comment.
Please review all changes and remove redundant comments
…n toggle button functionality
- Removed redundant code for updating sphere positions and clipping planes. - Introduced utility methods for better clarity and maintainability. - Enhanced error handling by using a consistent error variable naming convention. - Improved the organization of the code related to corner and face sphere calculations.
…state changes - Added event listener for VOLUMECROPPING_TOOL_CHANGED when the tool is enabled. - Removed event listener to prevent memory leaks when the tool is disabled. - Cleaned up commented-out code for better clarity in viewport initialization and tool selection logic.
…ne management - Introduced utility methods for retrieving volume actors and mappers. - Simplified clipping plane application logic by consolidating related functionality. - Improved error handling in viewport retrieval and ensured safe access to viewports info. - Cleaned up redundant code for better maintainability and clarity.
…ove clarity - Removed unnecessary comments throughout the code to enhance readability. - Streamlined the logic for handling annotations and viewport updates. - Improved organization of event listener management for tool state changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ticket: 18376011052
Changes & Results
feat(volumeCropping): Enhance volume cropping tool with clipping plane functionality and UI improvements
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.