Draft
Conversation
…fore failing tutorials were showing as passing. Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
…ean log file handler Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
…e multiple instances of the latter, once per source Signed-off-by: Israel Martinez <imc@umd.edu>
…_scatt_map > SC file refactoring Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
…r open the official FITS file, or parse the .ori file. It's better to keep it generic for now. Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Added the method apply_gti to SpacecraftHistory
…_gti Revert "Added the method apply_gti to SpacecraftHistory"
Updating TimeSelector
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
…n it was called SpacecraftFile) by jdbuhler in PR cositools#378 (using SLERP) Signed-off-by: Israel Martinez <imc@umd.edu>
# Conflicts: # cosipy/data_io/UnBinnedData.py # cosipy/event_selection/good_time_interval.py # cosipy/image_deconvolution/coordsys_conversion_matrix.py # cosipy/polarization/polarization_angle.py # cosipy/polarization_fitting/polarization_asad.py # cosipy/response/PointSourceResponse.py # cosipy/spacecraftfile/SpacecraftFile.py # cosipy/spacecraftfile/__init__.py # cosipy/test_data/image_deconvolution/unit_test_file.ipynb # cosipy/threeml/COSILike.py # cosipy/ts_map/fast_ts_fit.py # docs/tutorials/response/DetectorResponse.ipynb # docs/tutorials/response/PSR_with_Earth_occultation_example.ipynb # docs/tutorials/response/SpacecraftFile.ipynb # docs/tutorials/spectral_fits/extended_source_fit/diffuse_511_spectral_fit.ipynb # tests/image_deconvolution/test_coordsys_conversion_matrix.py # tests/image_deconvolution/test_exposure_table.py # tests/polarization/test_polarization_asad.py # tests/spacecraftfile/test_spacecraftfile.py # tests/ts_map/test_fast_ts_map.py
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
israelmcmc
force-pushed
the
interfaces
branch
2 times, most recently
from
87d3286 to
317ab82
Compare
# Conflicts: # cosipy/data_io/BinnedData.py # cosipy/data_io/UnBinnedData.py # cosipy/image_deconvolution/exposure_table.py # cosipy/source_injector/source_injector.py # cosipy/test_data/image_deconvolution/unit_test_file.ipynb # cosipy/threeml/COSILike.py # docs/tutorials/source_injector/Extended_source_injector.ipynb # docs/tutorials/source_injector/Point_source_injector.ipynb # docs/tutorials/spectral_fits/continuum_fit/crab/SpectralFit_Crab.ipynb # docs/tutorials/spectral_fits/extended_source_fit/diffuse_511_spectral_fit.ipynb # tests/image_deconvolution/test_exposure_table.py
Signed-off-by: Israel Martinez <imc@umd.edu>
…herical coordinates. Signed-off-by: Israel Martinez <imc@umd.edu>
* Change all Iterable[EventInterface] and Iterable[PhotonInterface] to EventDataInterface and PhotonListInterface. * EventSelection interface no longer defined __call__ and mask(). select() gained the early_stop parameter. * `direction_lon_radians` was renamed `direction_lon_rad_sc`. This is to make it consistent with other properties that define the coordinate or convention in the name, to make it less error-prone * Similarly, `polarization_angle_rad` changed to `polarization_angle_rad_stereo` Signed-off-by: Israel Martinez <imc@umd.edu>
… numpy arrays. The helper from_astropy class methods is provided (old init) Signed-off-by: Israel Martinez <imc@umd.edu>
…y direction * New intermediate class called PhotonListWithDirectionInSCFrame. The corresponding interface is the input of FarFieldInstrumentResponseFunctionInterface * FarFieldSpectralInstrumentResponseFunctionInterface with input PhotonListWithDirectionAndEnergyInSCFrame * Similar for polarization IRF Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Allow implementation to use already cached numpy arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress...
This is a major refactoring of cosipy to make it more modular, using interfaces (protocols) to decouple the inputs/outputs of different classes from their implementation.
There are currently three examples that serve as an entry point to see the interfaces usage:
Presentations:
20250630-CosipyInterfacesUpdate-Israel.pdf (at version 214f2ae)
Installation notes and troubleshooting:
crab.yamlandbackground.yamlin the repository or add it on wasabi incosipy_tutorialTODO list: