This repository was archived by the owner on Oct 15, 2020. It is now read-only.
WIP: Add Tests #31
Open
WIP: Add Tests #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
force-pushed
the
okwme/tests
branch
from
bd2a542 to
2bd960c
Compare
jackzampolin
reviewed
Feb 5, 2020
| require.NoError(t, err) | ||
| } | ||
|
|
||
| func TestScaffoldApp(t *testing.T) { |
Contributor
There was a problem hiding this comment.
can we also build/run the app here? Or is that better done in CI?
Contributor
There was a problem hiding this comment.
we can do app level scaffolding but not module level, which i think is fine. I can spend time next week working on this
Contributor
There was a problem hiding this comment.
I think app level is fine for now and adding module support to the testing at a later date.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added most basic tests for scaffold function
Not sure what the best testing strategy is here though.
Do we use golden files of a completed and correct build?
This might help us compare what is different and identify if something is missing / done wrong, but isn't actually testing the build of the files in any way....
Would love some input / opinions on techniques that might be helpful.