This repository was archived by the owner on Oct 15, 2020. It is now read-only.
chore: build the project #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Jan 28, 2020
| go test | ||
| cd go-bindata | ||
| go build | ||
| mv go-bindata /usr/local/bin/ No newline at end of file |
Contributor
There was a problem hiding this comment.
does it not automatically build it for you?. also if you have your GOBIN set then the mv shouldn't be necessary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project requires building
go-bindatafor gophers who have not installed it. I tried to add commands to build it in Makefile, but go does not allow building other projects inside a project root folder and makefile fixes the go command to be executed in the project root folder only. Eventually, I had to make a separate bash script that buildsgo-bindataand run it in Makefile.