Improvements to Ref<> #274
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang started noticing some format-string type mismatches
- `destroy()` method releases the reference, equivalent to `= nullptr` which is otherwise disallowed. This is for cases where a non-null reference needs to be released in e.g. a `close()` method, but it's understood that it can't be accessed again. This allows it to be typed as `Ref<>`. - `isValid()` returns false if the Ref has been destroyed. - `operator bool` is disallowed for Ref<>, because it's conceptually not nullable, so testing it is usually a sign that you're doing unnecessary checks. If you really need to check, use isValid().
Converted some `Retained` into `Ref`s. Fixed a template method in ValueSlot that didn't work with `Ref`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroy()method releases the reference, equivalent to= nullptrwhich is otherwise disallowed. This is for cases where a non-null
reference needs to be released in e.g. a
close()method, but it'sunderstood that it can't be accessed again. This allows it to be
typed as
Ref<>.isValid()returns false if the Ref has been destroyed.operator boolis disallowed for Ref<>, because it's conceptuallynot nullable, so testing it is usually a sign that you're doing
unnecessary checks. If you really need to check, use isValid().
Also converted some
Retaineds intoRefs in the Fleece codebase, and fixed a template method in ValueSlot that didn't work withRef.Also fixed some new clang printf warnings.