Add alternative getStatus() method to OperationFuture that takes time expiration parameters #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a method for `getStatus()` that takes expiration duration and TimeUnit parameters to be used with the the parametrized version of `get()`.
ryan-mccaffrey
changed the title
getStatus() method to OperationFuture that takes time expiration parameters
ryan-mccaffrey
changed the title
getStatus() method to OperationFuture that takes time expiration parameters
|
Review is up at http://review.couchbase.org/#/c/91951/ - unfortunately, this doesn't compile. |
ingenthr
requested changes
Apr 2, 2018
| public OperationStatus getStatus(long duration, TimeUnit units) { | ||
| if (status == null) { | ||
| try { | ||
| get(duration, units); |
There was a problem hiding this comment.
Fails to compile on this line. See http://review.couchbase.org/#/c/91951/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method for
getStatus()that takes expiration duration and TimeUnit parameters to be used with the the parametrized version ofget().Currently the only implementation of
getStatus()takes no parameters, and uses the defaulttimeoutduration when getting theOperationStatusof the operation. I found it useful to create a method that takeslong durationandTimeUnit unitsparameters to allow the client to specify timeout, as is already supported by the methodget(long duration, TimeUnit units).@daschl