Resolve hostname of node again during reconnection #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmarvin
force-pushed
the
master
branch
2 times, most recently
from
918325e to
e8d1be2
Compare
This is essential when memcached cluster is built on cloud infra, e.g. k8s, where nodes move and their ips vary.
|
Thank you for this. Saved us some headache. |
Onexx
reviewed
Jan 13, 2026
Comment on lines
+440
to
+441
| socketAddress = resolvedAddress; | ||
| getLogger().info("node address changed from %s to %s", |
There was a problem hiding this comment.
Thank you for this PR. Really saved us when we encountered this issue in production )
If anyone else comes across this pull request, I suggest adding this line so that the IP address in the logs is updated as well.
Suggested change
| socketAddress = resolvedAddress; | |
| getLogger().info("node address changed from %s to %s", | |
| socketAddress = resolvedAddress; | |
| connection.setName("Memcached IO over " + connection); | |
| getLogger().info("node address changed from %s to %s", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essential when memcached cluster is built on cloud infra, e.g. k8s, where nodes move and their ips vary.