Conversation
…ple under examples/writer-agent
Westwooo
reviewed
Aug 28, 2024
|
|
||
| let tpl_value = template.unwrap_or( "Please answer this question: \\\"{}\\\". Using the following context: \\\"{}\\\"".to_string()); | ||
| let mut rendered_tpl = tpl_value.replacen("{}", &*question, 1); | ||
| rendered_tpl = rendered_tpl.replacen("{}", &*context.join(" "), 1); |
Contributor
There was a problem hiding this comment.
This won't work, you'll just end up with the prompt without the question, since there are no "{}" to replace. You'd need to do something like:
let request_body = if let Some(tpl) = template {
format!("{} - {}", tpl, question)
} else {
format!(
"Please answer this question: \\\"{}\\\". Using the following context: \\\"{}\\\"",
question,
context.join(" ")
)
};
let question_with_ctx = if !context.is_empty() {
format!(
"{}. Using the following context: \\\"{}\\\"",
request_body,
context.join(" ")
)
} else {
request_body
};
And when using a custom prompt do we want to support users passing in context as well, or should they be mutually exclusive?
| model, self.api_key | ||
| ); | ||
|
|
||
| let tpl_value = template.unwrap_or( "Please answer this question: \\\"{}\\\". Using the following context: \\\"{}\\\"".to_string()); |
Contributor
There was a problem hiding this comment.
Same issue with this as the bedrock client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a configurable prompt for each model in the ask command, add example under examples/writer-agent. This would enable ai agents creation with cbsh.
Here is an example that specify answers must always be in JSON format: