Skip to content

Conversation

@sbluhm
Copy link
Contributor

@sbluhm sbluhm commented Jun 9, 2021

Users might need custom headers. Especially, if you want to allow CORS. For example:
Access-Control-Allow-Origin: 'https://www.example.com'
Access-Control-Allow-Headers: 'cache-control'

Enhancement #9
Replaces PR #24

@sbluhm
Copy link
Contributor Author

sbluhm commented Jun 9, 2021

Can you please have a look at line https://github.com/sbluhm/WebDAV-Daemon/blame/CustomHeaders/configuration.c#L296 for me?
I am not releasing the memory for xmlTextReaderGetAttribute here and have no clue how to do this. According to the documentation, you have to de-allocate it.

@sbluhm
Copy link
Contributor Author

sbluhm commented Aug 22, 2021

@couling

@sbluhm
Copy link
Contributor Author

sbluhm commented Jan 25, 2022

@couling going through my list of open PRs, I found this one. Can you please have a look for me?

Can you please have a look at line https://github.com/sbluhm/WebDAV-Daemon/blame/CustomHeaders/configuration.c#L296 for me?
I am not releasing the memory for xmlTextReaderGetAttribute here and have no clue how to do this. According to the documentation, you have to de-allocate it.

If this is fine the way it is, I would be happy to have this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant