Fix GCC build and add MAG274QRF-QD (3CC2) support#66
Open
aydiler wants to merge 2 commits intocouriersud:masterfrom
Open
Fix GCC build and add MAG274QRF-QD (3CC2) support#66aydiler wants to merge 2 commits intocouriersud:masterfrom
aydiler wants to merge 2 commits intocouriersud:masterfrom
Conversation
psteelseries.h uses uint8_t but doesn't include <cstdint>. This causes build failures with GCC 14+ which is stricter about implicit includes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds support for MAG274QRF-QD monitors with identifier 0x9a. This appears to be a 2023 production variant with the same V56 firmware as the existing MAG274QRF-QD FW.020 entry but with a different hardware identifier. Tested on: MAG274QRF-QD manufactured 2023.11 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <cstdint>to psteelseries.h0x9aDetails
Build Fix
psteelseries.husesuint8_twithout including<cstdint>. Newer GCC versions are stricter about implicit includes and fail to compile:Monitor Support
Adds support for MAG274QRF-QD monitors manufactured in late 2023 with variant code 3CC2. These units report identifier
00\x9ainstead of00ebut use the same V56 firmware.Monitor info:
00\x9aDebug output:
Test plan
🤖 Generated with Claude Code