Clarify format used in insertImage #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the format used by insertImage() explicit, allowing code that requires this information to depend on it symbolically rather than by examining the source. A case where this is useful is when specifying the MIME type in Intent.setType() when passing the result of insertImage as an Intent extra and attempting to invoke an activity that handles most "image/*" MIME types but that does not have a registered intent filter for "vnd.android.cursor.dir/image". In such a scenario, code might have hard-coded "image/jpeg" as a string; after this change, it becomes possible to use the STORED_CONTENT_TYPE variable, which would make such code less fragile.
|
I think you submitted this to the wrong upstream? I believe cozybit just forked this from elsewhere (although not in a way that it shows up as a fork in github). |
Author
|
Oops. Thanks. You're right. On Sun, Dec 14, 2014, 19:31 Bob Copeland notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the format used by insertImage() explicit, allowing code that requires this information to depend on it symbolically rather than by examining the source. A case where this is useful is when specifying the MIME type in Intent.setType() when passing the result of insertImage as an Intent extra and attempting to invoke an activity that handles most "image/*" MIME types but that does not have a registered intent filter for "vnd.android.cursor.dir/image". In such a scenario, code might have hard-coded "image/jpeg" as a string; after this change, it becomes possible to use the STORED_CONTENT_TYPE variable, which would make such code less fragile.