Open
Conversation
* Renamed ’ASCIImage’ (demo app) to ’ASCIImageDemo’ * Created a new shared OS X framework target ’ASCIImage’
Owner
|
@mchakravarty Sorry I am just seeing your pull request. I should get email notifications for those, but for some reason, I have not. Damn. Anyway, I need to first pull in PR #13, then see if it can be merged with this one. @esttorhe had also expressed interest in adding Carthage support. |
Owner
|
@mchakravarty Could you see if all works fine for you if you merge with the new |
Author
|
@cparnot I had the same problem as you. I assumed I would get an email notification when you respond, but I didn't (need to check my GitHub settings, I guess). I'll have a look at the new master. |
Owner
|
@mchakravarty Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds a new target that builds ASCIImage as a framework for OS X. This is useful to use tools like Carthage https://github.com/Carthage/Carthage to pull it into a project.
I renamed the two app targets, to be able to use the plain
ASCIImagefor the framework name.