Open
Conversation
Cleaner conditional require (reduces bundle size?). Also conditionally enable devTools.
cpetzel
approved these changes
Sep 9, 2022
movibe
approved these changes
Apr 3, 2023
cpetzel
approved these changes
Apr 4, 2023
cpetzel
requested changes
Apr 4, 2023
Owner
cpetzel
left a comment
cpetzel
left a comment
There was a problem hiding this comment.
I am not sure if metro allows conditional requires like this?
Its worth trying to make the code change and see what happens?
Author
|
IIRC it worked fine but it's been several months since I used this so not entirely sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaner conditional require (reduces bundle size?). Also conditionally enable devTools.