Skip to content

Conversation

@ckyang0225
Copy link
Contributor

@ckyang0225 ckyang0225 commented Jun 6, 2025

Add CPS examples as below:

cps-examples/
└── examples/
    ├── libbar.cps
    ├── libexample.cps
    └── libfoo.cps

Copy link
Member

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your interest!

However, there are several major problems with your examples:

  1. Version 0.9 is quite old. Please target the current version 0.13.
  2. Please use JSON, not YAML. While CPS itself does not specify a transport, JSON is the de facto standard. YAML is much more difficult to parse.
  3. Most of your examples have serious deviations from the specification.
  4. Direct use of compile/link flags is strongly discouraged.

@ckyang0225 ckyang0225 force-pushed the ckyang0225-addexample branch from 92a3a50 to 1473c42 Compare June 6, 2025 18:04
@ckyang0225
Copy link
Contributor Author

@mwoehlke-kitware Thanks for reviewing it, please take a look again to see if that's better or anything can be added.

Copy link
Member

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but there are still some schema-conformance issues. (Note: comments on 'libbar' may apply to other examples.)

Copy link
Member

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are hand-crafting these, please also validate them against the machine-readable schema.

@ckyang0225
Copy link
Contributor Author

@mwoehlke-kitware ok I just used https://www.jsonschemavalidator.net/ to validate these files and all looks good except link_location.

@mwoehlke-kitware
Copy link
Member

Thanks.

all looks good except link_location.

That's a false report; the current version of the schema doesn't understand that optional attributes may be null. cps-org/cps#93 hopefully fixes that.

@mwoehlke mwoehlke merged commit e857eb8 into cps-org:master Jul 24, 2025
@ckyang0225 ckyang0225 deleted the ckyang0225-addexample branch July 24, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants