Add component/configuration field for cpp module metadata #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwoehlke
reviewed
Aug 12, 2025
nickelpro
force-pushed
the
module-metadata
branch
2 times, most recently
from
1576e97 to
b510a7f
Compare
nickelpro
force-pushed
the
module-metadata
branch
from
b510a7f to
9142285
Compare
mwoehlke
approved these changes
Oct 20, 2025
Member
mwoehlke
left a comment
mwoehlke
left a comment
There was a problem hiding this comment.
I am tentatively approving this. I want to bring it up again at the next EE meeting (this Friday) in case anyone else has comments/concerns. Otherwise, please feel free to ping me after that if this hasn't landed or received other feedback.
Thanks!
mwoehlke
reviewed
Oct 21, 2025
nickelpro
force-pushed
the
module-metadata
branch
from
9142285 to
c4d5910
Compare
nickelpro
changed the title
nickelpro
force-pushed
the
module-metadata
branch
from
c4d5910 to
536eb3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
This allows us to trivially shim in C++ modules support while relying on an already in-production JSON format. No need to re-invent the wheel here.