Open
Conversation
…NiceStringFromCollection(targets)))'
Landmaster
reviewed
Jun 18, 2017
| import java.util.concurrent.Semaphore; | ||
|
|
||
| @Mod(modid="simpleretrogen", name="Simple Retrogen", acceptableRemoteVersions="*", acceptedMinecraftVersions = "[1.9,1.11)") | ||
| @Mod(modid="simpleretrogen", name="Simple Retrogen", acceptableRemoteVersions="*", acceptedMinecraftVersions = "[1.9,1.12]") |
There was a problem hiding this comment.
For consistency and to handle subversions of 1.12, the acceptedMinecraftVersions string should probably be set to [1.9,1.13).
Signed-off-by: Hexeption <minecraftfun201@gmail.com>
Signed-off-by: Hexeption <minecraftfun201@gmail.com>
Landmaster
suggested changes
Aug 7, 2017
| import java.util.concurrent.Semaphore; | ||
|
|
||
| @Mod(modid="simpleretrogen", name="Simple Retrogen", acceptableRemoteVersions="*", acceptedMinecraftVersions = "[1.9,1.11)") | ||
| @Mod(modid="simpleretrogen", name="Simple Retrogen", acceptableRemoteVersions="*", acceptedMinecraftVersions = "[1.9,1.12]") |
There was a problem hiding this comment.
This will not work with Minecraft 1.12.1; acceptedMinecraftVersions should be [1.9,1.13), not[1.9,1.12] .
Landmaster
suggested changes
Aug 7, 2017
| import java.util.concurrent.Semaphore; | ||
|
|
||
| @Mod(modid="simpleretrogen", name="Simple Retrogen", acceptableRemoteVersions="*", acceptedMinecraftVersions = "[1.9,1.11)") | ||
| @Mod(modid="simpleretrogen", name="Simple Retrogen", acceptableRemoteVersions="*", acceptedMinecraftVersions = "[1.9,1.13]") |
There was a problem hiding this comment.
You forgot to change the ] back to a ), since 1.13 is not targeted (i.e. the upper bound is exclusive).
Landmaster
approved these changes
Aug 11, 2017
|
@cpw ETA on merging this? |
|
This just fails with a number of compilation errors; are there changes to the build config also required? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.