-
Notifications
You must be signed in to change notification settings - Fork 684
avoid blank page on safari and firefox #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @crabbly Thanks @crabbly @acapellacci |
|
@acapellacci The most recent version of Print.js has not yet been published, unfortunately, so the chances are that the master branch actually works with Firefox v114? Do you have the issue with Firefox v114 using |
|
At least it was proven in the past that Firefox 110.0 does not work with the added timeout, so this PR might inadvertently reintroduce #665 for Firefox 110.0 ? If the timeout is needed for more recent versions of Firefox (114) and for some earlier versions (110.0) it should be removed, the condition should probably be still kept and needs to be more specific about the Firefox version? |
The issue occures in Safari 16.6 and Firefox 115 |
|
The code on npm is old, the current code seems to have a fix already. Here is how I managed to fix this issue:
npm i https://github.com/crabbly/Print.js
import printJS from "print-js/src/index.js";
printJS({printable: url, type: "pdf", frameRemoveDelay: 3000});The cause is the iframe is being removed too early |
Blank page issue still occurs with Firefox v114 and Safari. For this reason I propose to add a delay for both browsers and all versions.