Skip to content

Prevent duplication of GET parameters #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
infused-kim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent duplication of GET parameters #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ncm/ncm/ncm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
from requests import Session
from requests.adapters import HTTPAdapter
from http import HTTPStatus
from urllib.parse import urlencode
from urllib3.util.retry import Retry
from datetime import datetime, timedelta
import sys
Expand Down Expand Up @@ -220,8 +221,11 @@ def __get_json(self, get_url, call_type, params=None):
chunk_str = ','.join(map(str, chunk))
params.update({key: chunk_str})
url = get_url
if params is not None:
query_string = urlencode(params)
url = f'{url}?{query_string}'
while url and (len(results) < limit):
ncm = self.session.get(url, params=params)
ncm = self.session.get(url)
if not (200 <= ncm.status_code < 300):
break
self._return_handler(ncm.status_code,
Expand All @@ -233,8 +237,11 @@ def __get_json(self, get_url, call_type, params=None):

if __in_keys == 0:
url = get_url
if params is not None:
query_string = urlencode(params)
url = f'{url}?{query_string}'
while url and (len(results) < limit):
ncm = self.session.get(url, params=params)
ncm = self.session.get(url)
if not (200 <= ncm.status_code < 300):
break
self._return_handler(ncm.status_code, ncm.json()['data'],
Expand Down