Conversation
To integration test the GUI's event handling, we need a custom test harness that runs the examples on the main thread. We also need to use nextest for process isolation, since the eventloop is a singleton.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
===========================================
+ Coverage 94.01% 100.00% +5.98%
===========================================
Files 4 5 +1
Lines 451 673 +222
Branches 451 673 +222
===========================================
+ Hits 424 673 +249
+ Misses 22 0 -22
+ Partials 5 0 -5 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, refactor the GUI to be able to integration test the event loop. We use
nextestand a custom harness usinglibtest-mimicto make sure these examples run on the main thread, and each example gets its own process.This was a bit of a yak shave.